Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please install the required when the 'install' target is called #141

Open
yurivict opened this issue Oct 13, 2019 · 5 comments
Open

Please install the required when the 'install' target is called #141

yurivict opened this issue Oct 13, 2019 · 5 comments

Comments

@yurivict
Copy link

It currently doesn't install anything.

install.sh wouldn't do because it doesn't do the right things:

  1. It uses sudo that isn't needed to install the project
  2. It expects /usr/local/bin to be writable which isn't what should be done to install

The install target should install into $DESTDIR$PREFIX and should never need to use sudo.

@thbwd
Copy link
Member

thbwd commented Oct 13, 2019

install.sh doesn’t require sudo, it offers to use it if it cannot write into the installation directories.

The directories in which to install are fully customizable. The installer states this every time it is run:

If you prefer different locations you can rerun me and provide me with other locations like so:
	 ./install.sh [binary location] [packages location] [include location]

@yurivict
Copy link
Author

The installation process should be fully automatic. There's nobody there to read what the installaion script states.

@thbwd
Copy link
Member

thbwd commented Oct 13, 2019

Feel free to open a pull request that makes the necessary changes for this to run automatically (if possible in terms of calling install.sh, this is what I wanted to hint at).

@yurivict
Copy link
Author

Sorry, I don't have resources. I am only a package maintainer.

Project authors are expected to make projects installable, otherwise users would simply have no chance to even see your software because most people install software using package managers these days.

@Thesola10
Copy link

Thesola10 commented Aug 11, 2022

I don't see anything the install.sh script that CMake's install() function can't do, and better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants