Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display none on h1 in trix fields #294

Open
diogo-vf opened this issue Aug 8, 2023 · 3 comments
Open

Display none on h1 in trix fields #294

diogo-vf opened this issue Aug 8, 2023 · 3 comments

Comments

@diogo-vf
Copy link

diogo-vf commented Aug 8, 2023

  • Laravel Version: 9.41.9
  • Nova Version: 4.25.1
  • eminiarts/nova-tabs: 2.2.3
  • PHP Version: 8.1
  • Database Driver & Version: MySQL
  • Operating System and Version: Debian GNU/Linux 8 (jessie)
  • Browser type and version: Firefox Developer Edition (Version 117.0b3 (64-bit))

Description:

Within a tab, we notice a problem when trying to apply a heading tag to some text using a Trix field:
image

The text disappears, because there is a wrong style that sets display: none on the <h1> tag.
image

Detailed steps to reproduce the issue on a fresh Nova installation:

Write any text, it'll display as normal
image

After clicking on the Heading button, the text disappears from the interface.
You can see in the dev tools that the heading is display: none
image

@bram-pkg
Copy link

Bump, this is also causing issues for us.

FYI @diogo-vf we fixed it by adding:

.trix-content h1 {
    /* important is needed here because of the nova tabs making h1 display none */
    display: block !important;
}

To our theme.css, which you can register using Nova::style('my-app-name', resource_path('path/to/stylesheet.css'));

@diogo-vf
Copy link
Author

Bump, this is also causing issues for us.

FYI @diogo-vf we fixed it by adding:

.trix-content h1 {
    /* important is needed here because of the nova tabs making h1 display none */
    display: block !important;
}

To our theme.css, which you can register using Nova::style('my-app-name', resource_path('path/to/stylesheet.css'));

Thank you !

@phlisg
Copy link

phlisg commented Oct 25, 2023

Cheers for the temp fix @bram-pkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants