Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.2 release causes "TypeError [ERR_INVALID_ARG_TYPE]" (DH export missing?) #18

Open
cblgh opened this issue May 31, 2023 · 2 comments
Open

3.0.2 release causes "TypeError [ERR_INVALID_ARG_TYPE]" (DH export missing?) #18

cblgh opened this issue May 31, 2023 · 2 comments

Comments

@cblgh
Copy link

cblgh commented May 31, 2023 •
edited
Loading

We had a very strange bug arise in cabal where, suddenly, things were breaking for people when installing. And without us having done anything!

I tracked down the likely culprit to this commit and the 3.0.2 release of noise-protocol; when we explicitly pinned [email protected] the issues disappeared. For more details and a log dump see: cabal-club/cabal-cli#222

For now, we have pinned the previous version of noise-protocol, 3.0.1, as it does not cause any issues for us. Opening this issue in case it was unintended / not known about or if anyone else comes across this problem when relying on the library, however long down the dependency chain
@hackergrrl
Copy link

I just ran into this again, and following the breadcrumbs brought me here. :)

hackergrrl added a commit to hackergrrl/noise-protocol that referenced this issue Sep 21, 2024
@hackergrrl
Add dh.generateKeypair and dh.generateSeedKeypair to the public API.
801f85b 
There are modules like simple-hypercore-protocol which reach into the
`dh` object to access these functions, which has caused emilbayes#18. This commit
exposes them as part of the API proper, hopefully reducing the
likelihood of future breakages.
This was referenced Sep 21, 2024
Closed
Open
@hackergrrl
Copy link

@emilbayes Do you have thoughts on this? This causes emilbayes/simple-handshake#6 as well.

I'm still thinking about solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hackergrrl @cblgh