You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commit b2ae4c1 has introduced a regression in that it doesn't detect a downloaded subtitle - at least not in the way I use it.
Test case:
$ mkdir /tmp/movies
$ dd if=/dev/zero of=/tmp/movies/The\ Terror\ \(1963\).mkv bs=1024 count=2000
2000+0 records in
2000+0 records out
2048000 bytes (2.0 MB, 2.0 MiB) copied, 0.00466506 s, 439 MB/s
# Version 6.2 downloads once
$ python3 ./OpenSubtitlesDownload-6.2/OpenSubtitlesDownload.py --skip --auto --cli -u pmorch -p bogus /tmp/movies
>> Downloading 'en' subtitles for'The Terror (1963).mkv'# And notices it already exists when run the second time
$ python3 ./OpenSubtitlesDownload-6.2/OpenSubtitlesDownload.py --skip --auto --cli -u pmorch -p bogus /tmp/movies
>> A subtitles file already exists for this file:
/tmp/movies/The Terror (1963).srt
# But version b2ae4c1 keeps downloading it over and over again
$ python3 ./b2ae4c1/OpenSubtitlesDownload.py --skip --auto --cli -u pmorch -p bogus /tmp/movies
>> Downloading 'en' subtitles for'The Terror (1963).mkv'
$ python3 ./b2ae4c1/OpenSubtitlesDownload.py --skip --auto --cli -u pmorch -p bogus /tmp/movies
>> Downloading 'en' subtitles for'The Terror (1963).mkv'
The text was updated successfully, but these errors were encountered:
Indeed, every combination of separator symbols and language codes were tested, but not the base name + .srt :)
Thanks for noticing, this should be fixed in the latest commit!
Commit b2ae4c1 has introduced a regression in that it doesn't detect a downloaded subtitle - at least not in the way I use it.
Test case:
The text was updated successfully, but these errors were encountered: