Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bayesian recommendations from prior #130

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AdrianSosic
Copy link
Collaborator

@AdrianSosic AdrianSosic commented Feb 12, 2024

This PR enables the use of Bayesian recommenders for cases where no training data is available (i.e., using the prior only). This is done by:

  • ensuring that all dataframes are intact on the BayBE side even when they are empty
  • making sure that the models still return the desired result when presented an empty training data set

@AdrianSosic AdrianSosic added the new feature New functionality label Feb 12, 2024
@AdrianSosic
Copy link
Collaborator Author

Hi @AVHopp, @Scienfitz, this is the start of a PR enabling the use of the Bayesian recommenders without data, i.e. the missing piece to complete the TL example (#118) that allows to use the same recommender for the cases w/o training data, aligning the start of the learning curves. Unfortunately, due to time limitations, I could not manage to finish it, so either you take care of it or I do it after my return. The first part is done (i.e., ensuring that all dataframes are intact even when they contain no data) but now the botorch part needs adjustments.

@Scienfitz Scienfitz mentioned this pull request Feb 27, 2024
@Scienfitz Scienfitz added the on hold PR progress is awaiting for something else to continue label Apr 3, 2024
@Scienfitz
Copy link
Collaborator

Scienfitz commented Sep 9, 2024

@AdrianSosic since the surrogate refactoring the way should be open to finish this now. Or are there further issues from the Botorch side (if so lets track them here)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New functionality on hold PR progress is awaiting for something else to continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants