[Disco]: recommending on{event} instead of on-modifier

[NullVoxPopuli]

Motivation: krausest/js-framework-benchmark#1608

It's idiomatic to use {{on}} for event listening, and {{on}} is the only way to have conditionally applied / dynamic event listeners, but for performance sensitive situations, we can do less by using the platform, and we don't need any cleanup behavior, so native onclick should be sufficient.

[lifeart]

@NullVoxPopuli I remember some SSR concerns related to it, but can't find related topics.

Some outdated:

1. Syntax error when closure actions are interpreted ember-fastboot/ember-cli-fastboot#162
2. Add a compile time error when passing arguments to regular HTML elements (e.g. <a @foo=) glimmerjs/glimmer-vm#1102
3. Rehydration glimmerjs/glimmer-vm#549

[bertdeblock]

AFAIK, the {{on}} modifier was introduced as a better alternative to the on* properties => https://github.com/emberjs/rfcs/pull/471/files#diff-a1482043efff1d9e730b71a8ac6b323a1dedf4c0e3ac20f427944ccb1dbce355R38-R57

[NullVoxPopuli]

My research is showing better is debatable. In fact, specifically, situational (4-5 percent render speed improvement of using on*)

[lifeart]

@NullVoxPopuli here is proof on ~10% perf boost if we don't use removeEventListener

• experiment [on with removeEventListener] lifeart/glimmer-next#105 (comment)