-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis & parallelize autogenerated versionCompatibility scenarios #202
Comments
Unfortunately, there's no way to hook into Travis' parallel infrastructure and use the scenario autogeneration. The only way to use Travis' parallel infrastructure is the setup with the environment variable for the scenario, as seen in the .travis.yml generated by
I personally recommend |
Thanks for all the info! I'm surprised that the test stages can leak into the release stage... I'll remove
How is this possible? Maybe I'm missing an option. I tried this yesterday, here's the PR build. My |
Yeah, it's a bit tricky that the stages work that way. Alternatively, you could have the deploy stage reset the repo. I've found that it is often faster because it doesn't need to spin up all the containers + run an extra install for every container before ember-try can even be run. The primary cause of the very long run is:
If you run I recommend:
Yes, I recommend dropping support for versions of Ember that Ember itself no longer supports. 2.12 LTS is no longer supported after this month This will expand to 11 scenarios -- canary, beta, release, default, latest 2.8, latest 2.12, latest 2.16, latest 2.18, latest 3.0, 3.1, 3.2, 3.3 and any new minor versions as they are released. Some other things you can do to speed things up: I recommend only running lint as a stage and not as part of each |
I see. I think the linting tests are super fast, right? Also, how do you run your ember test suite and ignore the autogenerated linting tests? I think |
They are pretty fast, but it seems wasteful to lint for every scenario. If
you do it as a first stage with a fail fast, you can avoid running any
scenarios if linting does fail. To run test without lint, run `ember test
--query 'nolint'`. The first scenario run will be the `default` which is
floated deps, though the rest of the scenarios will run in the `ember
try:each` case; in the travis parallel case it would also fail fast.
…On Tue, Aug 14, 2018 at 5:03 PM, Sam Selikoff ***@***.***> wrote:
I see.
I think the linting tests are super fast, right? Also, how do you run your
ember test suite and ignore the autogenerated linting tests?
I think test:browser is for a fast failure – if the floating deps cause
an error I'd want to know after 1 build instead of running all versioned
tests. I think I got the idea from Robert. Is it a good idea?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#202 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbHOo9ot_05IK22kyN6f8lY0gRGVydiks5uQzsHgaJpZM4V64R4>
.
|
FYI - the issue with linting is not about speed, its about ensuring that the linting runs with the specific versions in your lockfile. When you lint as part of your ember-try config, you end up getting trolled by things like patch releases of prettier/eslint-plugin-node/etc. |
Is there a way to use
versionCompatibility
withember try:each
and have the jobs run parallel on Travis?Mirage's current
.travis.yml
looks like this and I'm wondering if there's a way to leverage the autogeneration piece from Ember Try, but still get parallel test runs in Travis.Alternatively, is there a current "best practice" around these setups? I'm seeing 2 or 3 different configs being used across popular projects.
The text was updated successfully, but these errors were encountered: