Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to getPageTitle test-support helper #212

Open
raido opened this issue Feb 12, 2021 · 0 comments
Open

Improvements to getPageTitle test-support helper #212

raido opened this issue Feb 12, 2021 · 0 comments

Comments

@raido
Copy link
Contributor

raido commented Feb 12, 2021

We probably should add comment block so IDEs could give hints of expected parameters OR provide TypeScript interface file. I think proper JSDoc for starters would be nice.

This helper does have some internal logic comments in it, we should probably remove it or separate it still for testing specifically this addon vs public helper.

The Array.pop() workaround for consumers is not needed, it's only applicable for tests in this repository.

Originally posted by @raido in #209 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant