-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Prettier standalone #10411
Comments
I'm a huge fan. Splitting out prettier speeds up eslint a ton, too
Probably do need an RFC, but rfcs can start as low effort placeholders if that's all a person has energy for 💪 |
I made this RFC issue a while ago, but closed it due to lack of time => emberjs/rfcs#901. Sharing just in case. |
Ember CLI blueprints run Prettier as part of the linters (ESLint, Stylelint). Prettier project explicitly recommends against doing so:
All those arguments seem to be valid for our use case as well. Additionally the integration of Prettier into linters has complicated the upgrade of Prettier, ESLint, Stylelint, Ember Template Lint iand related libraries n the past. For Prettier v3 many of those needed to be upgraded in a single PR due to limited sets of compatible versions.
Do we need a RFC to change how we integrate Prettier? Or do we consider it an implementation detail not requiring an RFC?
The text was updated successfully, but these errors were encountered: