-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the ImagePixelGetter trait #35
Comments
I'd like to add this. Though I think it should be named something like |
The trait already exists in the embedded-graphics master version, but not in a released version. |
Oh my bad, I didn't see that on the docs since it's not released yet. But I suppose it's a bit too late to change the name now. I was just thinking if the trait is new then one could still decide on the name. |
IMO it's not too late to change the name until there has been a release on crates.io. |
PR #34 did add a pixel getter method to
Bmp
andRawBmp
, but didn't yet implement the e-gImagePixelGetter
trait. TheBmp::pixel
method should be moved to aImagePixelGetter
trait impl when a new e-g version with this trait is released.The text was updated successfully, but these errors were encountered: