Params do not encode %20 to + or space

[anton89]

What version of Elysia is running?

1.1.25

What platform is your computer?

wsl

What steps can reproduce the bug?

import Elysia, { t } from "elysia";

const api = new Elysia().get("/:id", ({ params }) => params, {
  params: t.Object({
    id: t.String(),
  }),
});


const url = new URL("http://localhost:3000/hello world");
console.log(url.href);

const result = await api
  .handle(new Request(url.href))
  .then((response) => response.json() );
console.log("🚀 ~ result:", result)
//🚀 ~ result: { id: 'hello%20world' }

What is the expected behavior?

The id in params should be hello world

What do you see instead?

hello%20world

Additional information

Have you try removing the node_modules and bun.lockb and try again yet?

yes

[fredericoo]

i’d say behaving as expected — url parameters shouldn’t have special characters, otherwise it could behave erratically with routing (e.g.: /hello%2Fworld, would id be hello/world? Then if i go to /hello/world how will it know to escape the slash or not?)

to put it simply, the encoding of URI components in the pathname happens on the requester’s end (postman, insomnia, the browser) and elysia just takes it as it comes without decoding.

[anton89]

i’d say behaving as expected — url parameters shouldn’t have special characters, otherwise it could behave erratically with routing (e.g.: /hello%2Fworld, would id be hello/world? Then if i go to /hello/world how will it know to escape the slash or not?)

to put it simply, the encoding of URI components in the pathname happens on the requester’s end (postman, insomnia, the browser) and elysia just takes it as it comes without decoding.

but it already parsed and go through root endpoint ** shouldn't it just automatically encode it, if the id hello/world then it should go to hello first and then tried to encode world

this is the default behavior for queryString too btw

[macabeus]

The PR #958 also fixes this issue