Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: x-toggleclassonscroll #34

Open
4 tasks
elycruz opened this issue Jul 11, 2023 · 0 comments
Open
4 tasks

feature: x-toggleclassonscroll #34

elycruz opened this issue Jul 11, 2023 · 0 comments
Assignees
@elycruz
Labels
enhancement New feature or request new-feature triaged

Comments

@elycruz
Copy link
Owner

elycruz commented Jul 11, 2023 •
edited
Loading

Implement an element that allows triggering an action, and toggling a class name, on a target element, when targeted element intersects a scrollable target (default window view pane, by default).

Acceptance Criteria

  • Element should support choosing a scroll orientation to be triggered on - horizontal/vertical, and/or both.

  • Implementation.

  • Unit tests.

  • Documentation.

  • App story.
@elycruz elycruz self-assigned this Jul 11, 2023
elycruz added a commit that referenced this issue Jul 11, 2023
@elycruz
issue-#34 - Updated x-toggleclassonscroll control to only initialize …
33d4633 
…it's intersection observer only when absolutely necessary (on dom-node reconnect, and/or on required prop. updates).

- Performed minor code cleanup on control (prop names declaration orders).
- Progress on adding additional examples to x-toggleclassonscroll control.
elycruz added a commit that referenced this issue Jul 11, 2023
@elycruz
issue-#34 - Updated x-toggleclassonscroll control to only initialize …
534c0dc 
…it's intersection observer only when absolutely necessary (on dom-node reconnect, and/or on required prop. updates).

- Performed minor code cleanup on control (prop names declaration orders).
- Progress on adding additional examples to x-toggleclassonscroll control.
- Updated stylelint version numbers - Mismatched version numbers causes segfault when running tasks via pnpm.
elycruz added a commit that referenced this issue Jul 13, 2023
@elycruz
issue-#34 - Renamed 'container' property to 'trigger', on x-togglecla…
c47bbc4 
…ssonscroll component.
elycruz added a commit that referenced this issue Jul 14, 2023
@elycruz
issue-#34 - Progress on initial design spec finalization - Added prop…
7173364 
…erties.

- Added event handling example.
- Added doc. statements to component source.
elycruz added a commit that referenced this issue Aug 6, 2023
@elycruz
issue-#34 - Progress on initial design spec finalization - Added prop…
e1eccd9 
…erties.

- Added event handling example.
- Added doc. statements to component source.
@elycruz elycruz added enhancement New feature or request triaged new-feature labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
enhancement New feature or request new-feature triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elycruz