Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url.percentEncode also path segments #34

Closed
wants to merge 1 commit into from

Conversation

domenkozar
Copy link

Fixes #25

@hpate-omicron
Copy link

This would be great to have, it is a confusing issue to run into

@domenkozar
Copy link
Author

@evancz I'd appreciate if this was merged.

@hpate-omicron
Copy link

This would be nice to get in line with the RFC, this is the spec section for this piece that mentions percent encoding the path segments.
https://tools.ietf.org/html/rfc3986#section-3.3

@joshuakb2
Copy link

Is this fix going to be merged, and if not, why not?

@joshuakb2
Copy link

Is there any reason this hasn't been merged for over a year? I keep getting emails when people update the issue because they felt misled by the documentation. @domenkozar already fixed it, it just has to be merged. Is there something lacking here?

@evancz, can you help here? I don't know who else has the power to help us move forward on this issue.

@evancz evancz added breaking would require a MAJOR release request labels Feb 9, 2021
@domenkozar domenkozar closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking would require a MAJOR release request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path should also be escaped
4 participants