Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of elm-analyse.json #616

Open
razzeee opened this issue Jul 15, 2021 · 5 comments
Open

Get rid of elm-analyse.json #616

razzeee opened this issue Jul 15, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@razzeee
Copy link
Member

razzeee commented Jul 15, 2021

We should get rid of the file and switch to our own file format.

One idea would be to use the elm-tooling.json to handle these settings.

@lydell

@lydell
Copy link
Member

lydell commented Jul 18, 2021

I’m working on a tool myself (not public yet) that needs some config in elm-tooling.json. I’m doing it like this:

{
  "tools": {
    "elm": "0.19.1"
  },
  "x-elm-watch": {
    "whatever": "I want"
  }
}

I’m going to update elm-tooling validate to not complain about x-foo keys.

Maybe you can use that? My idea is that tooling authors can use this to get started, and then maybe standardize stuff later if it makes sense.

@razzeee
Copy link
Member Author

razzeee commented Jul 20, 2021

Sounds fine for me.

@razzeee
Copy link
Member Author

razzeee commented Jul 26, 2021

Then again, this will force users, that still use elm-analyse in their CI to maintain two files in sync.

The question is, are many people still using elm-analyse?

@lydell
Copy link
Member

lydell commented Aug 21, 2021

One could also ask the question: Does this create any benefit at all for end users, or are we just going to cause hassle for them having to move stuff from elm-analyse.json to elm-tooling.json?

It might feel cleaner for us, but maybe this is a historical quirk that doesn’t matter much. People have their elm-analyse.json set up and that works (if it ain’t broke, don’t fix it).

@razzeee
Copy link
Member Author

razzeee commented Aug 21, 2021 via email

@razzeee razzeee added the enhancement New feature or request label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants