Ecto.Changeset.changed?/2 returns false when setting assoc and errors when setting assoc to nil.

[jesenko]

Elixir version

1.17.2

Database and Version

PostgreSQL 15.8

Ecto Versions

3.12.4

Database Adapter and Versions (postgrex, myxql, etc)

postgrex, latest

Current behavior

   {:ok, existing_profile} = TestRepo.insert(%Profile{name: "profile"})

    changeset =
      %Author{}
      |> Changeset.change()
      |> Changeset.put_assoc(:profile, existing_profile)

    # currently returns false however it is clearly changed
    Changeset.changed?(changeset, :profile)


    changeset =
      %Author{profile: existing_profile}
      |> Changeset.change()
      |> Changeset.put_assoc(:profile, nil)

   # currently crashes 
   Changeset.changed?(changeset, :profile)

Expected behavior

   {:ok, existing_profile} = TestRepo.insert(%Profile{name: "profile"})

    changeset =
      %Author{}
      |> Changeset.change()
      |> Changeset.put_assoc(:profile, existing_profile)

    # should return true
    Changeset.changed?(changeset, :profile) == true


    changeset =
      %Author{profile: existing_profile}
      |> Changeset.change()
      |> Changeset.put_assoc(:profile, nil)

  # should return true
   Changeset.changed?(changeset, :profile) == true

[jesenko]

Related to #4544.

[jesenko]

Related PR just removes additional check changeset.action != :update or changeset.changes != %{} on assocs — no existing tests failed when removing this, however this might change behaviour of the function for some other cases for which it was initially added (not sure about original intent) 😬.

[josevalim]

Closing in favor of the PR. TY!