Case modify doesnt work

[rgwch]

The lock icon in "FallDetailBlatt2" doesn't seem to be funktional. Case details remain always locked and clicking on the lock symbol does not change anything.

I could not find out what's the problem, the logic to allow editing seems quite involved and includes several kinds of locks.

So I made just an "emergency fix" to make Elexis work vor me:

diff --git a/ch.elexis.core.ui/src/ch/elexis/core/ui/views/FallDetailBlatt2.java b/ch.elexis.core.ui/src/ch/elexis/core/ui/views/FallDetailBlatt2.java
index 5e41b83..ee13b0c 100644
--- a/ch.elexis.core.ui/src/ch/elexis/core/ui/views/FallDetailBlatt2.java
+++ b/ch.elexis.core.ui/src/ch/elexis/core/ui/views/FallDetailBlatt2.java
@@ -53,6 +53,7 @@
 import com.tiff.common.ui.datepicker.EnhancedDatePickerCombo;
 
 import ch.elexis.admin.AccessControlDefaults;
+import ch.elexis.admin.RoleBasedAccessControl;
 import ch.elexis.core.constants.Preferences;
 import ch.elexis.core.data.activator.CoreHub;
 import ch.elexis.core.data.events.ElexisEventDispatcher;
@@ -844,7 +845,7 @@
 			}
 		}
 		
-		boolean enable = lockEnabled && (allowFieldUpdate || invoiceCorrection);
+		boolean enable = (lockEnabled && (allowFieldUpdate || invoiceCorrection)) || CoreHub.acl.request(AccessControlDefaults.CASE_MODIFY_SPECIALS) ;
 		
 		tBezeichnung.setEditable(lockEnabled);
 		

The logic is: If the current User has the right CASE_MODIFY_SPECIALS then they may change case details. If not, the existing logic is applied. But someone should document when and how the lock can be opened.

[col-panic]

I am not sure, whether this is a bug! Can you check whether there was already an invoice existing for this specific Fall? If yes, it is deliberate that editing is not possible!

[rgwch]

The bill has the state "storniert". But that's not the point:

The lock should reflect its purpose and possibilities. If it can't unlock, it should be greyed-out/disabled, possibly with a tool tip telling the reason. If it's not greyed out, it should do something, when the user clicks on it. But it doesn't.

And, well it's not very useful to prevent to enter or correct e.g. insurance numbers at a later time. One needs far to much time to create a new case every time and move all consultations to that new case.

Allow modify with adequate rights is the correct way.