Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public folder symbolic icon doesn't have enough contrast in dark style #985

Open
JoseExposito opened this issue Jan 1, 2021 · 2 comments · May be fixed by #1181
Open

Public folder symbolic icon doesn't have enough contrast in dark style #985

JoseExposito opened this issue Jan 1, 2021 · 2 comments · May be fixed by #1181

Comments

@JoseExposito
Copy link
Member

JoseExposito commented Jan 1, 2021 •
edited by danirabbit

What Happened

This icon: https://github.com/elementary/icons/blob/master/places/symbolic/folder-publicshare-symbolic.svg
Does not have enough contrast in dark style.

Public icon bug

Expected Behavior

The icon should have more contrast or the folder version should be used when importing images to photos.

Steps to Reproduce

  1. Open the Photos app
  2. Click on Settings -> Import from folder
  3. The public folder icon doesn't have enough contrast

Platform Information

elementary OS 6

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@lainsce
Copy link
Contributor

lainsce commented Jan 1, 2021

Check out #938 I think it's the icon that is used here, but adapted to be more visible in dark mode.

@JoseExposito
Copy link
Member Author

Yes, it could be that icon. Let me know when your PR is merged so I can test it and close this issue 👍

@newhoa newhoa linked a pull request Jun 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Actions: Make send-to purple newhoa/icons
2 participants
@JoseExposito @lainsce