Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit-delete looks more like trash than delete #1173

Open
newhoa opened this issue Jan 6, 2023 · 1 comment
Open

edit-delete looks more like trash than delete #1173

newhoa opened this issue Jan 6, 2023 · 1 comment

Comments

@newhoa
Copy link
Collaborator

newhoa commented Jan 6, 2023

Problem

edit-delete is currently a symlink to user-trash. This makes the destructive delete action look like a non-destructive trash action.

Proposal

edit-delete should better represent a destructive delete action. Something more permanent like shredding, burning, etc. Something that looks more like a warning/danger than something recoverable and safe like trash.

@danirabbit
Copy link
Member

I think this is okay since when used in context there should always be an undo, either through a toast or through a trash or it should be used with the destructive-action css class. Legibility is more important than absolute accuracy I think. A new metaphor like burning or shredding would probably be unfamiliar for folks whereas as the trash can metaphor is used across other platforms and operating systems pretty consistently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants