Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [descriptions] fix slot parsing for description-items #18459

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tuskermanshu
Copy link
Contributor

closed #18452

The original implementation used flattedChildren(slots.default()).filter(...) to extract <el-descriptions-item> nodes, which did not account for nested or deeply embedded child nodes within custom components. This caused scenarios where descriptions items nested in other components were not being parsed correctly, resulting in incomplete or missing content in the final layout.

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Copy link

👋 @tuskermanshu, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

Hello @tuskermanshu, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18459

commit: e31980e

Copy link

github-actions bot commented Oct 8, 2024

🧪 Playground Preview: https://element-plus.run/?pr=18459
Please comment the example via this playground if needed.

@tuskermanshu
Copy link
Contributor Author

Playground

@makedopamine
Copy link
Collaborator

makedopamine commented Oct 14, 2024

Supporting that usage makes sense to me. However, if we support it, I think we should consider this similar usage. FYI, you can refer to Cascader or Tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] [Component] [descriptions] el-descriptions-item is not visible when slot into a component
2 participants