Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] the disabled state should render the input tag #18443

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

btea
Copy link
Collaborator

@btea btea commented Oct 4, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix #18442

Copy link

github-actions bot commented Oct 4, 2024

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 4, 2024
@@ -141,7 +141,6 @@
</el-tooltip>
</slot>
<div
v-if="!selectDisabled"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This judgment was specially added after the 2.5.0 refactoring. Do you still remember the reason why this judgment was added? @kooriookami

Copy link

pkg-pr-new bot commented Oct 4, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/element-plus/element-plus@18443

commit: a3fc91d

Copy link

github-actions bot commented Oct 4, 2024

🧪 Playground Preview: https://element-plus.run/?pr=18443
Please comment the example via this playground if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [select] Component does not render the input element when disabled
1 participant