Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error During Version Download Leaves UI in Bad State #1372

Open
dsanders11 opened this issue Jun 6, 2023 · 2 comments
Open

Error During Version Download Leaves UI in Bad State #1372

dsanders11 opened this issue Jun 6, 2023 · 2 comments
Labels
area:versions 🪲 bug Something isn't working

Comments

@dsanders11
Copy link
Member

A failed download will leave the action button in a bad state where you'll have to switch versions to recover. Also looks like it could happen in situations where you are offline, change versions, then come back online.

@dsanders11 dsanders11 added 🪲 bug Something isn't working area:versions labels Jun 6, 2023
@codebytere
Copy link
Member

Potentially related: on Windows, when switching versions fairly quickly, i keep seeing:

Failed to spawn Fiddle: EPERM: operation not permitted, unlink 'C:\Users\codebytere\AppData\Roaming\Electron Fiddle\electron-bin\current\electron.exe'

and then have to change versions again to get it to run

@dsanders11
Copy link
Member Author

Potentially related: on Windows, when switching versions fairly quickly, i keep seeing:

Hm, that's probably tripping over Windows quirks, unfortunately. With the change to using @electron/fiddle-core there's a bottleneck on electron-bin\current since versions are unzipped on-demand to save disk space, and Windows can get finicky when you are touching files a bunch. We may be able to mitigate it by using graceful-fs in the right spots in @electron/fiddle-core (see graceful-fs code comment which explains some of the Windows quirks).

@codebytere, just to confirm, you're seeing that behavior on 0.32.9? I would have thought #1367 would help mitigate that by not doing the unzip until a run happens, making switching between versions not touch electron-bin\current, but maybe there's some edge case there still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:versions 🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants