Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run from ASAR Support #100

Open
dsanders11 opened this issue Feb 25, 2024 · 1 comment
Open

Run from ASAR Support #100

dsanders11 opened this issue Feb 25, 2024 · 1 comment
Labels
good first issue Good for newcomers ✨ enhancement New feature or request

Comments

@dsanders11
Copy link
Member

In support of electron/fiddle#1551.

Would be nice if we could use @electron/asar to run a fiddle from an ASAR so we can exercise more code branches within Electron.

I think roughly this is what would need to be done in this repo:

  • Extend FiddleFactory constructor to take a new option, e.g. packAsAsar
  • Update FiddleFactory to use @electron/asar to package the fiddle into an ASAR when that option is used
  • Update tests to cover this case
@dsanders11 dsanders11 added ✨ enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2024
@hachimetsu hachimetsu mentioned this issue Mar 16, 2024
Open
@hachimetsu
Copy link

hello there !
I think i going in wrong direction can u guide me plz...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsanders11 @hachimetsu