fix: requestFullscreen
from WebContentsView
#41966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #41941.
Fixes an issue where
document.requestFullscreen
didn't work when calling it from awebContents
insideWebContentsView
. This was happening because we weren't setting the owner window to the associated NativeWindow after theWebContentsView
was added to one, and therefore the fullscreen transition wasn't being triggered.Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where
document.requestFullscreen
didn't work when calling it from awebContents
insideWebContentsView
.