New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Inconclusive Parsing of Content-Disposition Header #41939
Comments
This bug is happening due to a change that was made in this pull request. Unfortunately, if the onHeadersReceived is used and client code needs to modify headers, the original value of the constent-disposition header is lost. Moreover the new value incorrectly includes a space before the word attachment and it drops the value of filename*, which is what should be used to avoid issues with filename encoding on the client side. The PR should be undone. Reference to similar comment |
Preflight Checklist
Electron Version
30.0.0
What operating system are you using?
Windows
Operating System Version
Microsoft Windows [Version 10.0.19045.4291]
What arch are you using?
x64
Last Known Working Electron version
No response
Expected Behavior
The "content-disposition" header shouldn't be modified and work as in Chromium. Please, take a look at the screenshots I've attached. The problem is in the function HttpResponseHeadersToV8 - https://github.com/electron/electron/blob/main/shell/browser/api/electron_api_web_request.cc#L93C22-L93C45
Actual Behavior
Testcase Gist URL
https://gist.github.com/gdavidkov/08a8edae420a5b30e9f855f0ebb75a63
Additional Information
Ref: #25961
PR: #31669
The text was updated successfully, but these errors were encountered: