Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asar not verifying filenames before passing them to minimatch #238

Open
Stanzilla opened this issue Jun 11, 2022 · 0 comments
Open

asar not verifying filenames before passing them to minimatch #238

Stanzilla opened this issue Jun 11, 2022 · 0 comments
Assignees
Labels

Comments

@Stanzilla
Copy link

While working on tracking down a bug with sharp, we found that asar is not verifying file names before passing them to its minimatch dependency.

electron/asar@94cb8bd/lib/asar.js#L123

isaacs/minimatch@6410ef3/minimatch.js#L128

@erickzhao erickzhao added the bug label Jun 11, 2022
@erickzhao erickzhao self-assigned this Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants