-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing default install location is not respected #8164
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Ehm, ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to this custom-nsis-script , in question
How do change the default installation directory to custom?
there is sample of macro to use to set custom default install location.I use that successfully with previous version of
electron-builder
(v20x), but in current version (24x) this functionality is broken.Same bug was reported in #6369 but was closed due to inactivity ? That problem still persist in latest version.
My observations:
my project uses (till now) version
20.38.5
ofelectron-builer
and when i set custom install location via recommended NSI script:and
productName
isMyCompany Super Product
and run MSI installer (without changing install location in installer UI) my app is properly installed inc:\MyApp
where i can find exe file eg.c:\MyApp\myapp.exe
- this is expected and validBut updating to latest version
24.9.1
with samensi
preInit script, and values, my app is installed into folderc:\MyApp\MyCompany Super Product
and exe is found inc:\MyApp\MyCompany Super Product\myapp.exe
- this is unexpected and wrong.I found (thanks to @xyyHIT) what causing this is in file
app-builder-lib/templates/nsis/assistedInstaller.nsh
and functioninstFilesPre
, where old was:but new one has:
missing
${If}
on first line of function. Maybe this change fixes some other issue or was changed by mistake. Can you elaborate this? For now im stuck on older version.The text was updated successfully, but these errors were encountered: