Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Add functional tests for search source ES query rule data view changes #183160

Open
davismcphee opened this issue May 10, 2024 · 1 comment
Labels
Feature:Alerting Feature:Functional Testing impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects

Comments

@davismcphee
Copy link
Contributor

We recently fixed an issue in #182883 where changes to a data view that impact the time field could cause the search source ES query rule to fail. This was done as a quick fix to get into the next 8.14 patch release, so we relied on manual testing to validate the fix. This is a followup issue to add necessary functional test coverage for this scenario, specifically these tests:

  • When a data view's index pattern and/or time field changes, existing rules based on the data view should succeed using the updated time field.
  • When a data view's time field is removed, existing rules should fail with the an error that the data view no longer contains a time field.
@davismcphee davismcphee added Feature:Alerting loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:Functional Testing Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels May 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine kibanamachine added this to Inbox in Discover May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Feature:Functional Testing impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Development

No branches or pull requests

2 participants