Use Kubernetes/Helm recommended labels

[aabouzaid]

Describe the feature:

Currently, in all charts/versions, the old Helm labels are used e.g. release, chart, and app.
Helm has already moved from those labels since 2018, and a new set of labels has been introduced and recommended by Helm and Kubernetes.

Describe a specific use case for the feature:

Working with the resources that created by Elastic Helm charts is not unified and doesn't follow the best practices in terms of labeling.

If you agree to the change, I will make the change for each chart one by one (we could also keep the old behavior for compatibility and to be deprecated later).

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[aabouzaid]

@jmlrt wdyt about this?

[jmlrt]

Hey @aabouzaid, thanks for opening this issue. While I agree that it would make sense to use the Helm best practices here, this could break all existing deployments during the upgrade, that's why we decided to not do it. Following the recent announcement in #1731, we don't expect to update the existing.

[aabouzaid]

@jmlrt couldn't we simply add the new labels without removing the old ones?

[jmlrt]

I guess we could but not sure when we would have some time for review tbh

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.