Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searchable snapshot should not be able to be deleted if it's in use by a frozen index #108450

Closed
kunisen opened this issue May 9, 2024 · 3 comments · Fixed by #108451
Closed

Searchable snapshot should not be able to be deleted if it's in use by a frozen index #108450

kunisen opened this issue May 9, 2024 · 3 comments · Fixed by #108451
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team

Comments

@kunisen
Copy link
Contributor

kunisen commented May 9, 2024 •
edited

Elasticsearch Version

8.13.3

Installed Plugins

No response

Java Version

bundled

OS Version

major

Problem Description

We found a doc bug for searchable snapshot. (cc @geekpete)

Description

The searchable snapshot doc says this:

You also cannot delete a snapshot if any of its indices are mounted as a searchable snapshot in the same cluster.

But we found actually we can delete even it’s mounted. Please see the screenshot.

Our concern

:: [1]
It literally means we have no protection to searchable snapshot, even it’s being mounted to frozen indices. People have deletion permission can delete it.
(We are not talking about deleting the frozen index, but only talking about deleting searchable snapshot directly)
Can we add this guardrail logic to make this statement become really true, or at least remove this part?

:: [2]
Also, if a customized SLM wants to delete searchable snapshot, it should error out too, based on the same context.

Our testing result:

image

Reference

Steps to Reproduce

Prepare frozen index and searchable snapshot

PUT _cluster/settings
{"persistent":{"indices.lifecycle.poll_interval":"10s"}}

# create ilm policy for frozen
DELETE _ilm/policy/test-frozen-policy
PUT _ilm/policy/test-frozen-policy
{
  "policy": {
    "phases": {
      "hot": {
        "min_age": "0m",
        "actions": {
          "set_priority": {
            "priority": 100
          }
        }
      },
      "frozen": {
        "min_age": "1m",
        "actions": {
          "searchable_snapshot": {
            "snapshot_repository": "found-snapshots"
          }
        }
      }
    }
  }
}


# create template for frozen indices
DELETE _template/test-frozen-template
PUT _template/test-frozen-template
{
  "index_patterns": ["test-frozen-index*"],
  "settings": {
    "lifecycle": {
      "name": "test-frozen-policy"
    },
    "number_of_shards": 1,
    "number_of_replicas": 1
  }
}

# create index for frozen
DELETE test-frozen-index-1
POST test-frozen-index-1/_doc
{
  "field1": "someValue"
}

Check searchable snapshot is created and try delete it

# this is the frozen index
GET partial-test-frozen-index-1/_settings

GET _snapshot/found-snapshots/2024.05.09-test-frozen-index-1-test-frozen-policy-tsqt9tzqtyququi2qcdohw

# response - searchable snapshot is in place and mounted to frozen index
{
  "snapshots": [
    {
      "snapshot": "2024.05.09-test-frozen-index-1-test-frozen-policy-tsqt9tzqtyququi2qcdohw",
      "uuid": "Jxzs_GCNTy-e8uHs00MqQQ",
      "repository": "found-snapshots",
      "version_id": 8503000,
      "version": "8503000",
      "indices": [
        "test-frozen-index-1"
      ],
      "data_streams": [],
      "include_global_state": false,
      "state": "SUCCESS",
      "start_time": "2024-05-09T07:24:22.541Z",
      "start_time_in_millis": 1715239462541,
      "end_time": "2024-05-09T07:24:22.941Z",
      "end_time_in_millis": 1715239462941,
      "duration_in_millis": 400,
      "failures": [],
      "shards": {
        "total": 1,
        "failed": 0,
        "successful": 1
      },
      "feature_states": []
    }
  ],
  "total": 1,
  "remaining": 0
}


DELETE _snapshot/found-snapshots/2024.05.09-test-frozen-index-1-test-frozen-policy-tsqt9tzqtyququi2qcdohw

# response - but we can delete it
{
  "acknowledged": true
}

Logs (if relevant)

No response
@kunisen kunisen added >bug needs:triage Requires assignment of a team area label :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs :Data Management/ILM+SLM Index and Snapshot lifecycle management labels May 9, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Distributed Meta label for distributed team labels May 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 9, 2024
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue May 9, 2024
@DaveCTurner
Clarify docs on deleting searchable snapshots
80b251b 
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see elastic#73947). This
commit clarifies this by saying `must not` instead.

Closes elastic#108450
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue May 9, 2024
@DaveCTurner
Clarify docs on deleting searchable snapshots
ccf94ba 
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see elastic#73947). This
commit clarifies this by saying `must not` instead.

Closes elastic#108450
@DaveCTurner DaveCTurner mentioned this issue May 9, 2024
Merged
@DaveCTurner DaveCTurner added >docs General docs changes and removed :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team labels May 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label May 9, 2024
DaveCTurner added a commit that referenced this issue May 9, 2024
@DaveCTurner
Clarify docs on deleting searchable snapshots (#108451)
91bed34 
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see #73947). This
commit clarifies this by saying `must not` instead.

Closes #108450
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue May 9, 2024
@DaveCTurner
Clarify docs on deleting searchable snapshots (elastic#108451)
d36400c 
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see elastic#73947). This
commit clarifies this by saying `must not` instead.

Closes elastic#108450
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue May 9, 2024
@DaveCTurner
Clarify docs on deleting searchable snapshots (elastic#108451)
f989355 
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see elastic#73947). This
commit clarifies this by saying `must not` instead.

Closes elastic#108450
elasticsearchmachine pushed a commit that referenced this issue May 9, 2024
@DaveCTurner
Clarify docs on deleting searchable snapshots (#108451) (#108478)
ac1322f 
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see #73947). This
commit clarifies this by saying `must not` instead.

Closes #108450
elasticsearchmachine pushed a commit that referenced this issue May 9, 2024
@DaveCTurner
Clarify docs on deleting searchable snapshots (#108451) (#108479)
460850e 
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see #73947). This
commit clarifies this by saying `must not` instead.

Closes #108450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify docs on deleting searchable snapshots DaveCTurner/elasticsearch
3 participants
@DaveCTurner @kunisen @elasticsearchmachine