Fix ClassCastException in Significant Terms #108429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @not-napoleon, I've created a changelog YAML for you. |
iverase
reviewed
May 9, 2024
| @Override | ||
| public void accept(InternalAggregation aggregation) { | ||
| @SuppressWarnings("unchecked") | ||
| final InternalSignificantTerms<A, B> terms = (InternalSignificantTerms<A, B>) aggregation; | ||
| if (referenceAgg == null) { |
There was a problem hiding this comment.
You need to skip Unmapped fields. Adding at the beginning should be enough:
if (aggregation.canLeadReduction() == false) {
return;
}
…g-terms' into bug-CCE-in-sig-terms
iverase
approved these changes
May 9, 2024
markjhoy
pushed a commit
to markjhoy/elasticsearch
that referenced
this pull request
May 9, 2024
Prior to this PR, if a SignificantTerms aggregation targeted a field existing on two indices (that were included in the aggregation) but mapped to different field types, the query would fail at reduce time with a somewhat obscure ClassCastException. This change brings the behavior in line with the Terms aggregation, which returns a 400 class IllegalArgumentException with a useful message in this situation. Resolves elastic#108427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #108427
Prior to this PR, if a
SignificantTermsaggregation targeted a field existing on two indices (that were included in the aggregation) but mapped to different field types, the query would fail at reduce time with a somewhat obscureClassCastException. This change brings the behavior in line with theTermsaggregation, which returns a 400 classIllegalArgumentExceptionwith a useful message in this situation.