[Bug] "non-functional in v1.16+; use the "priorityClassName" field instead" warning during eksctl deployment

[jackylu0124]

What were you trying to accomplish?

I am trying to create a EKS cluster with the eksctl create cluster -f cluster.yaml command (see my cluster.yaml file content in the reproduction section).

What happened?

I saw the following warning in the log during cluster creation:

4400 warnings.go:70] spec.template.metadata.annotations[scheduler.alpha.kubernetes.io/critical-pod]: non-functional in v1.16+; use the "priorityClassName" field instead

How to reproduce it?

Run eksctl create cluster -f cluster.yaml on the following config file (cluster.yaml):

apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: test-cluster-001
  region: us-east-1

vpc:
  autoAllocateIPv6: false
  cidr: 10.108.0.0/16

managedNodeGroups:
- name: ng-0
  desiredCapacity: 1
  maxSize: 1
  minSize: 1
  instanceType: g4dn.xlarge
  volumeSize: 50

Logs

Warning log:

4400 warnings.go:70] spec.template.metadata.annotations[scheduler.alpha.kubernetes.io/critical-pod]: non-functional in v1.16+; use the "priorityClassName" field instead

Anything else we need to know?

My OS is Windows 11, and I used the downloaded binary.
Versions

$ eksctl info
eksctl version: 0.175.0
kubectl version: v1.27.2
OS: windows

[github-actions]

Hello jackylu0124 👋 Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

[TiberiuGC]

Hi @jackylu0124 - we only keep scheduler.alpha.kubernetes.io/critical-pod annotation for backwards compatibility purposes.

eksctl/pkg/addons/assets/nvidia-device-plugin.yaml

Lines 28 to 31 in 0229468

	# This annotation is deprecated. Kept here for backward compatibility
	# See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
	annotations:
	scheduler.alpha.kubernetes.io/critical-pod: ""

But the daemonset also has priorityClassName configured.

eksctl/pkg/addons/assets/nvidia-device-plugin.yaml

Lines 43 to 47 in 0229468

	# Mark this pod as a critical add-on; when enabled, the critical add-on
	# scheduler reserves resources for critical add-on pods so that they can
	# be rescheduled after a failure.
	# See https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/
	priorityClassName: "system-node-critical"