Releases: eic/EICrecon
Releases · eic/EICrecon
v1.7.0
What's Changed
🕸️ Tracking
- fix: use unique_ptr for geometry in DD4hep_service, hand out not_null const pointers by @wdconinc in #1045
- fix: reenable storing geometryId into TrackPoint surface field by @wdconinc in #1055
- feat: fill Acts::GeometryIdentfier extra field with DD4hep detector ID by @wdconinc in #1058
- fix: IWYU pragmas and iwyu.imp fixes by @wdconinc in #1079
- fix: apply all automatic IWYU suggestions (and 2 fixes by hand) by @wdconinc in #1080
- fix: use edm4hep vector_utils instead of edm4eic; remove MaterialWiper (prep for Acts v26) by @wdconinc in #1082
- fix: print magnetic field strength in correct units in ActsGeometryProvider by @wdconinc in #1077
- treewide: avoid including some internal headers from libstdc++ by @veprbl in #1083
- replace trackersourcelinker with trackermeasurement by @ShujieL in #1076
- updated MAPS threshold by @kkauder in #1089
🪪 Particle identification
- rm ECGEM by @kkauder in #1044
- fix: support fmt v10 and C++20 by @wdconinc in #1073
- updated ECTOF threshold by @kkauder in #1091
- updated BTOF threshold by @kkauder in #1090
🚿 Calorimetry
- treewide: fix spelling by @veprbl in #1042
- fix: remove adhoc LFHCAL treatment in CalorimeterHitReco by @wdconinc in #1054
- Remove factories for HcalEndcapP by @veprbl in #1062
- Adjust reconstruction parameters for Barrel ECal by @mariakzurek in #1078
- calorimetry_CalorimeterIslandCluster: add test case for adjacencyMatrix code path by @veprbl in #1088
- Bhcal threshold by @kkauder in #1095
- Updated EEMC energy threshold and ADC parameters by @kkauder in #1100
- Updated backward HCAL ADC parameters, removed threshold by @kkauder in #1102
- Consolidated BEMC thresholds and ADC parameters by @kkauder in #1094
◀️ Backward
⏩ Far Forward
⚙️ Infrastructure
- feat(ci): release notes definition by @wdconinc in #1041
- fix(ci): avoid lsan crashes with intercept_tls_get_addr=0 by @wdconinc in #1048
- feat(ci): test eicmkplugin in CI by @wdconinc in #1031
- feat: enable ubsan by default in CI, with print_stacktrace=1 and suppressions by @wdconinc in #987
- [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #1063
- ci: include-what-you-use, clang-include-fixer by @wdconinc in #755
- feat: remove epic_brycecanyon as main configuration by @wdconinc in #1038
- linux-eic-shell.yml: remove last reference to brycecanyon by @veprbl in #1084
- feat(ci): allow changing jug_xl:nightly as basis for CI jobs by @wdconinc in #1087
- linux-eic-shell.yml: fix cancel-in-progress by @veprbl in #1097
New Contributors
Full Changelog: v1.6.0...v1.7.0
v1.6.2
What's Changed
- [Backport v1.6] TrackPropagation_factory: HcalEndcapN_* is not defined anymore, use LFHCAL by @epic-capybara in #1065
Full Changelog: v1.6.1...v1.6.2
v1.6.1
v1.6.0
What's Changed
🕸️ Tracking
- fix: unused header cleanup by @wdconinc in #932
- fix: remove non-POD-ness from OrthogonalTrackSeedingConfig by @wdconinc in #931
- fix: unused header cleanup by @wdconinc in #934
- fix: clang-tidy readability-qualified-auto by @wdconinc in #762
- feat: allow configuring WITH_SHARED_LIBRARY and WITHOUT_PLUGIN by @wdconinc in #940
- fix: resolve CKFTracking memory leak by @wdconinc in #979
- fix: address memory leaks in TrackSeeding by @wdconinc in #983
- fix: address memory leaks in TrackProjector by @wdconinc in #982
- fix: address memory leaks in IterativeVertexFinder by @wdconinc in #981
- Revert "CKFTracking: disable RTTI type checks until EICrecon conforms to ODR (#551)" by @veprbl in #1015
- feat: use our spdlog::logger for Acts logging by @wdconinc in #1012
- fix: address clang-tidy clang-analyzer warnings by @wdconinc in #1013
🪪 Particle identification
- fix: Compiler warning in src/tests/algorithms_test/pid_MergeParticleID.cc by @c-dilks in #929
- fix: disable DRICH radiator and photon vertex cheat code by @wdconinc in #967
- fix: avoid undefined unsigned integer behavior in pid size checks by @wdconinc in #984
- Reducing number of track projections inside dRICH by @chchatte92 in #999
🚿 Calorimetry
- fix: memory leak in CalorimeterClusterRecoCoG by @wdconinc in #974
- fix: avoid undefined behavior in signed integer 0 bitwise complement by @wdconinc in #985
- feat: std::optional in cluster reco CoG by @wdconinc in #1000
- fix: rename JDD4hep_service to DD4hep_service by @wdconinc in #1001
- fix: move some info logging to debug; remove unneeded fmt::format by @wdconinc in #1007
- fix: avoid division by zero by not setting weighted position if sum of weights is zero by @wdconinc in #989
- feat(ci): updates to lsan.supp and require PRs to pass leak checks by @wdconinc in #980
⏩ Far Forward
- remove unused OffMomentumReconstruction_factory., RomanPotsReconstruction_factory. by @veprbl in #1033
- fix: rm unused FarForwardParticles by @wdconinc in #1037
⚙️ Infrastructure
- docs: apk add ttf-freefont for graphviz without boxes by @wdconinc in #926
- feat(ci): publish GitHub pages site with PR information (no fork) by @wdconinc in #923
- fix: unset PODIO_JSON_OUTPUT after loading EDM4HEP, EDM4EIC by @wdconinc in #916
- feat(ci): no cancel-in-progress on main by @wdconinc in #939
- fix(ci): don't use pre-filled JANA_PLUGIN_PATH with EICrecon plugins by @wdconinc in #942
- fix: enable rpath on build and install linking by @wdconinc in #938
- fix(ci): ignore when clang-tidy doesn't produce any fixes by @wdconinc in #893
- fix: rm doxygen from PRs by @wdconinc in #951
- pr-backport.yml: add github token by @veprbl in #954
- fix(ci): use npsim instead of ddsim by @wdconinc in #955
- feat: new janatop plugin, i.e. janadot without the svg output by @wdconinc in #963
- linux-eic-shell.yml: enable on maintenance branches by @veprbl in #966
- ci: pre-commit clang-format (but not CI) by @wdconinc in #753
- fix(ci): cancel in progress when ref_name != refs/heads/main by @wdconinc in #968
- fix: use RPATH in build tree, unset LD_LIBRARY_PATH for ctest by @wdconinc in #978
- feat(ci): correct LD_LIBRARY_PATH prefix and add job step to print
ldd *.so
by @wdconinc in #986 - feat(ci): add job to run each benchmark separately by @wdconinc in #848
- fix(ci): cancel-in-progress false for main by @wdconinc in #998
- fix: set LD_LIBRARY_PATH for benchmark tests by @wdconinc in #1002
- fix(ci): run ctest with prefixed LD_LIBRARY_PATH by @wdconinc in #1010
- fix(ci): avoid API rate exceeding in get-docs-from-open-prs with max-parallel: 4 by @wdconinc in #1006
- fix(ci): get-docs-from-main for last success workflow, not merely completed by @wdconinc in #995
- feat: add two-stage test job (digitization/reconstruction); write EventHeader by default by @wdconinc in #1014
- ci: ccache max size increase and show stats; key name changes by @wdconinc in #774
- fix: remove all odr violations, and enforce them in ASAN_OPTIONS by @wdconinc in #1023
- labeler.yml: fix calorimetry tag for EHCAL by @veprbl in #1028
- [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #1039
New Contributors
- @chchatte92 made their first contribution in #999
Full Changelog: v1.5.0...v1.6.0
v1.5.1
What's Changed
- [Backport v1.5] ChargedParticleSelector: fix compilation by @veprbl in #953
- [Backport v1.5] fix: use xyz_g[3] in richgeo/ReadoutGeo.cc by @epic-capybara in #964
- [Backport v1.5] fix: disable DRICH radiator and photon vertex cheat code by @epic-capybara in #969
New Contributors
- @epic-capybara made their first contribution in #964
Full Changelog: v1.5.0...v1.5.1
v1.5.0
What's Changed
- fix(RICH): minimize number of failed track propagation attempts by @c-dilks in #735
- ImagingTopoCluster: avoid storing copies of the hits by @veprbl in #839
- fix: allow for = in working dir for datamodel glue by @wdconinc in #844
- fix: remove unused includes of ParticlesFromTrackFitResult.h by @wdconinc in #847
- fix: move jana ticker pausing from CKFTracking into ActsGeo service by @wdconinc in #846
- ci: set {ASAN/LSAN}_OPTIONS for whole workflow by @wdconinc in #849
- feat: convert CKFTracking factory to multifactory by @wdconinc in #850
- fix: rm unused output{Seeded}Particles from TrackingResult_factory by @wdconinc in #852
- services/log: remove timestamp from log messages, allow configuring format by @veprbl in #851
- CalorimeterHitDigi: use energy same smearing in signal_sum_digi as in single_hits_digi by @veprbl in #854
- CalorimeterIslandCluster,ImagingTopoCluster: use breadth first search by @veprbl in #841
- CalorimeterHitDigi: remove duplicate calculation from signal_sum_digi by @veprbl in #855
- fix: readd license and provenance of ActsExamples files by @wdconinc in #853
- Realistic scfi/imaging energy/position cluster merger by @wdconinc in #822
- fix: depend on datamodel version headers in datamodel glue by @wdconinc in #843
- ci: don't fail when if_no_artifact_found: warn by @wdconinc in #863
- CalorimeterIslandCluster: add back the references by @veprbl in #858
- feat: use podio collections in tracking digi/reco; rm unused interfaces by @wdconinc in #840
- Revert "feat: use podio collections in tracking digi/reco; rm unused interfaces (#840)" by @wdconinc in #869
- fix: apply the specified time resolutions to tracking reco algorithm by @wdconinc in #870
- fix: restore merging of hits in TrackerHitCollector by @wdconinc in #868
- fix: mv init TrackParameters edm4eic to ActsExamples conversion into algorithm by @wdconinc in #859
- CalorimeterHitDigi: don't add a hit when none of the merged hits meet the timing requirement by @veprbl in #856
- add .github/workflows/labeler.yml by @veprbl in #866
- linux-eic-shell.yml: install epic-capybara by @veprbl in #874
- feat: use podio collections in tracking digi/reco; rm unused interfaces (3rd attempt) by @wdconinc in #872
- Digitization for hpDIRC sensor plane by @niwgit in #861
- feat: produce edm4eic::TrajectoryCollection in CKFTracking by @wdconinc in #860
- feat: remove SmearedFarForwardParticles by @wdconinc in #878
- Upgrade Jet Factories to Multifactories by @ruse-traveler in #767
- refactor(dRICH): compatibility update for PDU readout by @c-dilks in #727
- CalorimeterHitDigi: unified code path for digitization with and without the hit merging by @veprbl in #864
- fix: remove custom_environment.sh and cmake_wrapper.sh by @wdconinc in #876
- reco: add *ChargedJets by @veprbl in #881
- fix: require EDM4eic 2.1 minimum by @wdconinc in #885
- fix(dRICH):
CentralCKFTrajectories
->CentralCKFActsTrajectories
by @c-dilks in #880 - labeler.yml: correct paths for "topic: backward" by @veprbl in #886
- feat(ci): allow merge queues by @wdconinc in #887
- fix: link DIRC/DRICH detectors against digi_library with PhotoMultiplierDigi_factory by @wdconinc in #888
- Update BHCal energy thresholds by @ruse-traveler in #883
- fix: don't try to write non-existent collections by @wdconinc in #889
- feat!: link dRICH PID with
Reconstructed*ChargedParticles
by @c-dilks in #829 - feat!: enable dRICH PID in production by @c-dilks in #734
- feat: remove tabs in pre-commit by @wdconinc in #891
- Common transfer matrix algorithm by @simonge in #879
- [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #896
- fix: delete space points on TrackSeeding by @wdconinc in #877
- fix: change "no matching CherenkovParticleID" log level
warn
->trace
by @c-dilks in #918 - Changed kinematic calculations to use edm4eic vector utils in ParticlesWithPID by @simonge in #914
- Added LowQ2 plugin with hit digitization by @simonge in #919
- fix: move Eigen out of SpdlogFormatters by @wdconinc in #920
- Silicon thresholds by @kkauder in #890
- Create TrackPropagation_factory by @tylerkutz in #862
New Contributors
- @niwgit made their first contribution in #861
- @simonge made their first contribution in #879
- @tylerkutz made their first contribution in #862
Full Changelog: v1.4.0...v1.5.0
v1.4.1
v1.4.0
What's Changed
- fix: missing comma in tracking.cc by @wdconinc in #748
- fix(richgeo): DD4hep CellID type by @c-dilks in #749
- ci: run clang-tidy on PR diff and post suggestions by @wdconinc in #752
- linux-eic-shell.yml: fix llvm-cov for PRs from fork by @veprbl in #756
- Add reconstructed electron factory, algorithm utilizing E/p cut by @jdbrice in #751
- fix: OffMomentumReconstruction_factory should use JFactoryPodioT by @wdconinc in #759
- fix:
#include <string>
in CalorimeterClusterRecoCoGConfig by @wdconinc in #760 - fix: clang-tidy modernize-use-emplace by @wdconinc in #764
- fix: clang-tidy readability-container-size-empty by @wdconinc in #763
- linux-eic-shell.yml: fix the apt-get failures by @veprbl in #769
- README.md: add CI status badge by @veprbl in #768
- feat: more modern CMake by using targets instead of include_directories by @wdconinc in #720
- fix: rewrite TrackParamTruthInit to create edm4eic::TrackParameters by @wdconinc in #766
- TrackParamTruthInit: revert accidental swap of theta and phi error values by @veprbl in #779
- feat: use -gz if supported in Debug and RelWithDebInfo by @wdconinc in #777
- ci: collect all jana.dot and jana.svg into single artifact, and publish by @wdconinc in #776
- feat: make the factory-factory a variadic template (more evil things) by @wdconinc in #784
- fix: rm unused podio_access code by @wdconinc in #787
- fix: rm unused trk_chain_example code by @wdconinc in #788
- fix: place truth vertex on perigee surface in truth seeding by @wdconinc in #783
- ci: default to brycecanyon, craterlake by @wdconinc in #789
- Added CKF tracking with real seeds. by @bschmookler in #711
- ci: (not quite so) basic diff with target branch by @wdconinc in #773
- fix: disable default inclusion of realistic seeder by @wdconinc in #790
- feat: convert calorimetry JFactoryT to JChainFactoryT by @wdconinc in #785
- fix: GeneratedParticles: ignore MCParticles with generatorStatus != 1 by @wdconinc in #772
- algorithms/calorimetry: pass PODIO collections instead of std::vector by @veprbl in #741
- feat: rewrite MC2SmearedParticle to operate on collections by @wdconinc in #778
- feat: rewrite InclusiveKinematics algorithms to operate on podio collections by @wdconinc in #780
- feat(PID): merge Cherenkov Particle ID results by @c-dilks in #730
- fix: rm failing MC2SmearedParticleConfig include by @wdconinc in #792
- fix: use proper local header quoting by @wdconinc in #801
- fix: rm unused TruthCluster_factory_B0ECalTruthProtoClusters (duplicate) by @wdconinc in #805
- fix: pre-commit codespell, avoid common spelling mistakes by @wdconinc in #802
- fix: typo in JChainFactoryGeneratorT type by @wdconinc in #793
- feat: Calorimeter hit digi simplification by @wdconinc in #794
- feat: Calorimeter hit reco simplification by @wdconinc in #797
- fix: rm unused/non-functional run_examples/full_flags_run.py by @wdconinc in #811
- fix: rm unmaintained log_example (should go in docs, or user shoudn't need) by @wdconinc in #812
- fix: remove
using namespace std
(only in cc files) by @wdconinc in #810 - drop SciGlass by @veprbl in #809
- feat: CalorimeterHitsMerger factory simplification by @wdconinc in #803
- feat: CalorimeterTruthClustering simplification by @wdconinc in #806
- fix: rm unused and unmaintained pyjano by @wdconinc in #813
- fix: rm CRTP on SpdlogMixin, variadic template factory, unnecessary
using
in factories by @wdconinc in #808 - fix: rm unused and empty podio test since #578 by @wdconinc in #814
- fix: rm unimplemented csh support by @wdconinc in #816
- feat: rm utility
StringHelpers.h
from which only one function ever used by @wdconinc in #818 - fix: rm README with dead AWS S3 links by @wdconinc in #819
- fix: restore LGPL license for algorithms by @wdconinc in #820
- [pre-commit.ci] pre-commit autoupdate by @pre-commit-ci in #823
- Reverted default Silicon Tracker Digi threshold to 0 by @kkauder in #825
- algorithms/calorimetry/CalorimeterIslandCluster: pass PODIO collections instead of std::vector by @veprbl in #791
- fix: read
materials-map
string constant in ACTSGeo_service by @wdconinc in #826 - feat: migrate the imaging calorimeter algorithms to collections and modern factories by @wdconinc in #807
- fix: convert ImagingPixelReco to use CalorimeterHitReco by @wdconinc in #830
- feat: convert ProtoCluster factories to single CalorimeterIslandCluster_factoryT by @wdconinc in #828
- fix: clang-tidy modernize-loop-convert by @wdconinc in #765
- CalorimeterIslandCluster: compile adjacencyMatrix expressions using cling by @veprbl in #824
- fix: rename imaging/scfi module to sector by @wdconinc in #836
- rename EcalBarrelImagingMergedClusters -> EcalBarrelClusters by @veprbl in #835
- fix: Simplified track seeder findPCA (was: findROOT) function and guard against returning NaN values by @bschmookler in #804
- update max eta forward limit in truth seeder to 6 by @rahmans1 in #834
New Contributors
- @jdbrice made their first contribution in #751
- @pre-commit-ci made their first contribution in #823
- @kkauder made their first contribution in #825
Full Changelog: v1.3.0...v1.4.0