Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackParamTruthInitConfig: maxEtaForward=10 for B0 coverage #1662

Closed
wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 2, 2024

We should cover down to 5.5 mrad.
The new value eta=10 covers that:

>>> import numpy as np
>>> np.rad2deg(2*np.arctan(np.exp(-10)))
0.005202448727587163

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

We should cover down to 5.5 mrad.
The new value eta=10 covers that:
```
>>> import numpy as np
>>> np.rad2deg(2*np.arctan(np.exp(-10)))
0.005202448727587163
```
@veprbl veprbl linked an issue Nov 2, 2024 that may be closed by this pull request
@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Nov 2, 2024
@michael-pitt
Copy link
Contributor

I need to test it, but I think the covered eta is up to 6 (we usually report eta<5.9):

>>>-np.log(np.tan(5.5e-3/2))
5.896151846465876

The inner radius of the tracking layers defines this. If the tracking layer is 3.5cm from the beam center, which at the distance of 630cm gives this opening angle of np.arctan(3.5/630).

@ajentsch
Copy link
Contributor

ajentsch commented Nov 3, 2024

Going to an eta of 10 is putting us in the vicinity of the Roman pots and the OMD, which are both silicon trackers, and would potentially allow for very unphysical tracks to be reconstructed with ACTS. I would recommend only going to eta of 6.0.

@veprbl
Copy link
Member Author

veprbl commented Nov 3, 2024

Yeah, I think there are couple mistakes in my estimate, I target 5.5 mdeg instead of 5.5 mrad. And also it doesn’t account for the crossing angle. Yet it works to at least have some seeds get produced, instead of not having any.

@veprbl
Copy link
Member Author

veprbl commented Nov 14, 2024

Based on what's discussed on Mattermost, it sounds like this isn't useful.

@veprbl veprbl closed this Nov 14, 2024
@veprbl veprbl deleted the pr/truth_seeding_fix_for_b0 branch November 14, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tracks in the B0 tracking sequence
3 participants