From fe43bd6a3145c29a3d4e897a42945b3447003663 Mon Sep 17 00:00:00 2001 From: Sakib Rahman Date: Fri, 26 Jul 2024 16:36:23 -0400 Subject: [PATCH] Remove redundant edm4eic RawCalorimeterHit type (#87) ### Briefly, what does this PR introduce? Remove redundant edm4eic RawCalorimeterHit type. EICrecon uses edm4hep RawCalorimeterHit type everywhere which has signed members instead of unsigned ones here. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior? --- edm4eic.yaml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/edm4eic.yaml b/edm4eic.yaml index 9de1462..13b70f2 100644 --- a/edm4eic.yaml +++ b/edm4eic.yaml @@ -234,17 +234,6 @@ datatypes: ## ========================================================================== ## Calorimetry ## ========================================================================== - edm4eic::RawCalorimeterHit: - Description: "Raw (digitized) calorimeter hit" - Author: "W. Armstrong, S. Joosten" - Members: - - uint64_t cellID // The detector specific (geometrical) cell id. - - uint64_t amplitude // The magnitude of the hit in ADC counts. - ## @TODO: should we also add integral and time-over-threshold (ToT) here? Or should - ## those all be different raw sensor types? Amplitude is - ## really not what most calorimetry sensors will give us AFAIK... - - uint64_t timeStamp // Timing in TDC - edm4eic::CalorimeterHit: Description: "Calorimeter hit" Author: "W. Armstrong, S. Joosten"