Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please open a PR with necessary changes to gopher-lua #1

Open
tul opened this issue Dec 14, 2019 · 3 comments
Open

Please open a PR with necessary changes to gopher-lua #1

tul opened this issue Dec 14, 2019 · 3 comments

Comments

@tul
Copy link

tul commented Dec 14, 2019

Thanks for making this. You say that if the author of gopher lua accepted your patch that you would no longer need to replace gopher lua.

I couldn't find this patch in the PRs if the gopher lua project. Please open it if you haven't already then it can be considered.

Thanks

@edolphin-ydf
Copy link
Owner

edolphin-ydf commented Dec 15, 2019

My modification to gopher-lua is based on this pr. Before , i 'm waiting for the author to merger that pr. And now , i'v added this issue

@edolphin-ydf
Copy link
Owner

edolphin-ydf commented Dec 15, 2019

But because of this, i think the author may not want this feature been in the main repo.

@tul
Copy link
Author

tul commented Dec 15, 2019

Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants