Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update included editorconfig-core-py to support python3.11 #28

Open
SimonHeimberg opened this issue Jul 14, 2023 · 3 comments
Open

update included editorconfig-core-py to support python3.11 #28

SimonHeimberg opened this issue Jul 14, 2023 · 3 comments

Comments

@SimonHeimberg
Copy link
Contributor

SimonHeimberg commented Jul 14, 2023 •
edited
Loading

I got the error re.error: global flags not at the start of the expression at position 15

This is fixed by editorconfig/editorconfig-core-py@6722ab5, which is included in v0.12.3

I fixed this locally by copying the changed lines linked above.

Global flags at the start of the expression were deprecated since python 3.6 and got invalid in python 3.11 (from Python-Markdown/markdown#1312).
@SimonHeimberg
Copy link
Contributor Author

I am also fine to have it as (up to date) submodule, as suggested in #17
And to tag a new version #26 is still a good idea.

@xuhdev
Copy link
Member

xuhdev commented Jul 19, 2023

Updated, please give it a try.

@SimonHeimberg
Copy link
Contributor Author

Updated, please give it a try.

It works 🍾 🎉 Thanks
And thank you for the hint in README.md. I never heard about subtree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuhdev @SimonHeimberg