Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved compatibility with Windows by providing zip binary archives #321

Closed
Okeanos opened this issue Jan 22, 2024 · 4 comments
Closed

Comments

@Okeanos
Copy link
Contributor

Okeanos commented Jan 22, 2024

As very briefly mentioned in #204

Then, I think it's better to have Windows releases in zip format, since there is no .tar.gz support natively, I use 7zip for that.

It would be very, very cool if you could provide Windows binary releases as .zip archive instead of .tar.gz – Windows isn't natively able to unpack/work with .tar.gz. This makes it especially troublesome because tools such as winget are also not able to deal with .tar.gz either.

Providing .zip files would open up a lot of additional fancy integration possibilities via e.g. winget and related tooling making adoption on Windows way easier and nicer.

@Okeanos
Copy link
Contributor Author

Okeanos commented Feb 21, 2024

Closed by accident when going through my list of open issues. Apologies for any confusion.

@Okeanos
Copy link
Contributor Author

Okeanos commented Feb 27, 2024

@mstruebing I may be able to provide a PR for this but just to be sure I am not overlooking anything too obvious … the relevant change would be in the Makefile and probably involve a Windows vs. everything else check, right?

@mstruebing
Copy link
Member

@Okeanos yes you are right. Except you would want to compress all binaries as zips.
The wrapper (php, javascript, pyhton) will need to adjust anyway so I would think one format which can be used anywhere would be better than making exceptions - if that's possible. But I guess zip is common on every OS.

Okeanos added a commit to Okeanos/editorconfig-checker that referenced this issue Aug 21, 2024
…cker#321)

This adds a zip archive to the output of the compress-all-binaries sub-task in
order to provide better compatiblitiy with Windows.

Windows does not come with the ability to handle tar.gz (until now the only
output format) and, hence, users cannot easily use the prebuilt binaries
distributed via GitHub. Further integration into, for example, the winget
community packages is also prevented by this.

Zip was chosen as an _additional_ output format in order to not create an
unexpected/breaking change for consumers of the existing tar.gz format.

Windows is not handled specifically here in order to keep the process of
providing build artifacts as simple as possible.
mstruebing pushed a commit that referenced this issue Aug 23, 2024
This adds a zip archive to the output of the compress-all-binaries sub-task in
order to provide better compatiblitiy with Windows.

Windows does not come with the ability to handle tar.gz (until now the only
output format) and, hence, users cannot easily use the prebuilt binaries
distributed via GitHub. Further integration into, for example, the winget
community packages is also prevented by this.

Zip was chosen as an _additional_ output format in order to not create an
unexpected/breaking change for consumers of the existing tar.gz format.

Windows is not handled specifically here in order to keep the process of
providing build artifacts as simple as possible.
@theoludwig
Copy link
Member

This issue should probably be closed as #362 have been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants