-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different results with and without installed Git #261
Comments
If you look at the lines after your referenced one (which has an editorconfig-checker/pkg/files/files.go Lines 98 to 104 in e2ce8ab
Prior to this there was an explicit ignore for You did not state if A newer version of On a host where Here's an example, note how you need to escape the {
"IgnoreDefaults": false,
"Exclude": [
"^test/bats/",
"^test/test_helper/bats-(assert|support)",
"^test/test-files/",
"\\.git/"
]
} |
@polarathene Is |
I am only marked as a contributor because I had a PR updating the README merged. Not my documentation? 😅 The project I am active on is So no, it's probably not an officially supported filename 🤷♂️ Easy enough for you to check though 👍 |
@polarathene Sorry for this! I just opened an issue. Please, upvote if you believe it will add value to the project. Thanks! |
I was trying to understand why I get different results while running
ec
in the container with mounted volume vs on host directly. In particular, it was checking binary files in the.git
folder.The culprit seems to be that under the hood
ec
is invoking Git to get a list of files in the repo:editorconfig-checker/pkg/files/files.go
Line 98 in e2ce8ab
This is not mentioned anywhere in the docs and no warning is issued when Git binary is not available or the command fails for other reasons.
Ideally, this has to be configurable. Something like
-no-git
option to preserve backward compatibility + a warning in case the Git support is enabled but fails.I might be willing to take a stab at this if you're ok with the idea 😺 .
The text was updated successfully, but these errors were encountered: