Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mix task to reset queues #167

Open
tlvenn opened this issue Jul 2, 2018 · 9 comments
Open

Add mix task to reset queues #167

tlvenn opened this issue Jul 2, 2018 · 9 comments

Comments

@tlvenn
Copy link
Contributor

tlvenn commented Jul 2, 2018

I saw this with task_bunny and I think it's pretty useful in dev

https://github.com/shinyscorpion/task_bunny#reset-queues

@edgurgel
Copy link
Owner

edgurgel commented Jul 2, 2018

Oh yeah that would be a great addition. It should be very simple to SSCAN for queue:* and remove all of them + inprogress I think?

@klebervirgilio
Copy link

@tlvenn @edgurgel Can I work on this one?

@edgurgel
Copy link
Owner

edgurgel commented Jul 8, 2018

Fine by me! 👍 Thanks!

@klebervirgilio
Copy link

klebervirgilio commented Jul 9, 2018

About removing the queues, do you guys think would be a good idea to only remove the queues listed in the config files?

Something like: https://github.com/klebervirgilio/verk/commit/c5242a1ad452e000224cc158dfb175bbf5dd2389

@edgurgel
Copy link
Owner

edgurgel commented Jul 9, 2018

I think that's good enough for now. I'm not sure how common is the use case of starting queues dynamically 👍

@tlvenn
Copy link
Contributor Author

tlvenn commented Sep 4, 2018

Hi @klebervirgilio, could you please make a PR so we can review and merge? Thanks !

@klebervirgilio
Copy link

klebervirgilio commented Sep 6, 2018

@edgurgel @tlvenn before I open a PR, I was wondering, do you think is a good idea use Verk.Queue instated of calling Redix directly?

IMO, the good thing about it would be that Verk.Queue is the module where knowledge about queue should live.

@edgurgel
Copy link
Owner

Hey sorry for the late reply!

I agree Do you mind adding a new function to Verk.Queue and using it for the mix task?

@tlvenn
Copy link
Contributor Author

tlvenn commented Nov 9, 2018

Hi @klebervirgilio , any update on your progress ?
Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants