-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python Suggestion] Linting #438
Comments
Yeah, I think that'll be great! Thank you for the proposal, feel free to go ahead with incremental PRs. ❤️
Agreed! Let's fix the errors and turn it on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there!
I was wondering if there was any interest in general python project related improvements/contributions?
I made a linting proof of concept with pre-commit, a great tool I use in all my project (even non-Python). I have added a
lint
target in the Makefile to reflect this intention.https://github.com/adehad/edgedb-python/pull/1/files
There are quite a few things it runs, but I think the autoformatters
black
andruff
can be a great asset to run (can even be configured via the pre-commit github action that can autoformat pull requests).ruff
can be used to swap outflake8
to run on the generated file too if desired.Ideally the
mypy
(static type checker) should be run, but looks like there are quite a few errors at the moment.Happy to help (maybe in smaller increments) if this is something you are considering and/or need help with
The text was updated successfully, but these errors were encountered: