Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galleries with links in the caption open the link instead of the gallery #15

Closed
edgan opened this issue Dec 20, 2024 · 1 comment
Closed

Galleries with links in the caption open the link instead of the gallery #15

edgan opened this issue Dec 20, 2024 · 1 comment

Comments

@edgan
Copy link
Owner

edgan commented Dec 20, 2024

This is an old bug I found in the original git repository's issues. The core issue is that this post has a non-gallery url. Yet you can detect it is a gallery with the is_gallery attribute in the json. Slide depends on JRAW. JRAW mostly uses the url to determine the type. In this case JRAW doesn't support the submission attribute is_gallery. So first it needs to be added to JRAW, and then to Slide.

Haptic-Apps#3472

Slide version: 6.7.10
Android version: 15
edgan added a commit that referenced this issue Dec 20, 2024
@edgan
Added support for detecting a gallery by the is_gallery attribute #15
e64ed25 
Switched to a new custom version of JRAW forked from ccrama's to add
the above feature, and new features in the future
@edgan
Copy link
Owner Author

edgan commented Dec 20, 2024

Fixed with 6.7.11

@edgan edgan closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edgan