Adjust the format of the new concept requests to follow the "official issue templates"

[hmenager]

After suggesting a new concept with EDAM browser, the format of the generated issue should be similar to the following issue templates:

• For formats https://github.com/edamontology/edamontology/issues/new?assignees=&labels=&template=new-format.md
• For data https://github.com/edamontology/edamontology/issues/new?assignees=&labels=&template=new-data.md
• For identifiers https://github.com/edamontology/edamontology/issues/new?assignees=&labels=&template=new-identifier.md
• For operations https://github.com/edamontology/edamontology/issues/new?assignees=&labels=&template=new-operation.md
• For topics https://github.com/edamontology/edamontology/issues/new?assignees=&labels=&template=new-topic.md

[hmenager]

Here is a hopefully more detailed and understandable description of this issue: whenever a user goes to edam-browser, they can navigate the ontology and select a given concept, for instance "Bioinformatics".

If the person finds that there is a missing child concept (e.g. here, a topic which would be a child of "Bioinformatics"), he can click on the [+] button on the top right of the Panel Details of term "Bioinformatics".

This will lead them to a new window that allows to provide the information which should be when asking for a new term.

Once they are done providing this information, they click on the [continue to GitHub] button at the bottom right, and end up (after authentication in github) on an issue page which is nicely preformatted. As you can see if you try for yourself, the text for this preformatted issue (title and body) have been simply passed as get parameters to the issue creation page.

A nice improvement would be to modify the code which generates these parameters, so that they align more with the format of what is provided in the standard issue templates mentionned above, and results in concept requests such as edamontology/edamontology#609.

[raashika03]

Now it's crystal clear, thanks @hmenager, will implement this.

[bryan-brancotte]

for information, this issue is a partial duplicate of #27

[raashika03]

@hmenager @bryan-brancotte @matuskalas
I came out with this implementation by looking at the original js code for this issue. I coded this in c++ for easier explanation to decrease the length of this comment. Check it out once and see if I'm heading in the right direction. If this goes well then just I need to convert this into js.

string arr[5]=["format","data","identifier","operation","topic"];
//This matrix kind structure will store the value of attributes for all the branches. like 1st row will have attributes(defined in new concept template) of format branch, similarly for other rows. 5 rows total with variable length of column for each branch
vector<vector> attribute_matrix_kind[5]; //0-format, 1-idata, 2-dentifier, 3-operation, 4-topic,
//creating map kind structure which will store the no. of attributes corresponding to each branch code(0, 1, 2, 3, 4)
unordered_map<int,int> umap;
//finding the no. of elements in each branch
for(int i=0;i<5;i++)
umap[i]=attribute_matrix_kind[i].size();

string var = current_branch;
int i;
//finding the no. code of present branch
for(i=0;i<5;i++){
if( var == arr[i] ) break;
}

//vectors to store input or selected values.
vectorselected_data, new_values;
for(int j=0;j<umap[i];i++){
//generate input boxes in the propose change page;
//fill up selected_data or new_values vectors as per the format of given input;
}

//Now on calling function send_to_github()
//printing the attributs and values corresponding to that branch
for(int k=0;k<umap[i]<k++){
cout<< attribute_matrix_kind[i][k]<<"<"<<(selected_data[k] || new_values[k])<<">";
}

[raashika03]

Or should I use 16 for no. of attributes for Format type as defined in the new format so that I don't need to count for the no. of attributes for the selected branch. Counting will be needed when I'll generalise, so that if in future no. of attributes is increased then the maintainer don't need to change the code manually for reading those newly added attributes.
What should I do? @bryan-brancotte

[raashika03]

Hi @bryan-brancotte can you review this once 😅

[bryan-brancotte]

Hi, I don't completely get what you are talking in the c++ message and the following message. What I can say is that this issue is not about editing the user interface in the website, it is to change the text of the issue generated by the app and sent to github. Hope this will help