-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Angular 18 support #2336
Comments
I'm already working to add support for Angular 18. Here is my first findings:
|
When running test for angular-material, I get lot of the following error:
If I move the code from angular-test to angular-material directly, the tests run. I wonder why the angular-test package is needed, since it is only used from angular-material. Should we not simply move all the code from angular-test to angular-material? @JBBianchi Since you did the previous Angular upgrade. Maybe you can help here? |
I must admit I didn't understand either what was the use of having a specific module angular-test if it's only use in one other module anyways. I don't have a lot of time currently but I can try to have a look in the next weeks. |
Hi! Thanks for raising this issue and proactively working on it 👍 The Angular test package is only there for historic reasons, I don't see a problem with removing it if it makes the overall task easier. |
Is your feature request related to a problem? Please describe.
Angular 18 will be released in the week of 20.05.2024 (https://angular.io/guide/releases). The library should supports the new version.
Describe the solution you'd like
Support for Angular 18.
Describe alternatives you've considered
No alternative.
Framework
Angular
RendererSet
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: