Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Angular 18 support #2336

Closed
laurentgrangier opened this issue May 13, 2024 · 4 comments · Fixed by #2340
Closed

Add Angular 18 support #2336

laurentgrangier opened this issue May 13, 2024 · 4 comments · Fixed by #2340
Labels
Milestone

Comments

@laurentgrangier
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Angular 18 will be released in the week of 20.05.2024 (https://angular.io/guide/releases). The library should supports the new version.

Describe the solution you'd like

Support for Angular 18.

Describe alternatives you've considered

No alternative.

Framework

Angular

RendererSet

No response

Additional context

No response

@laurentgrangier
Copy link
Contributor Author

I'm already working to add support for Angular 18. Here is my first findings:

  • Angular 18 needs Typescript 5.2.x. Typescript should be updated to all modules. Support for Angular 16 must be dropped because it needs Typescript >=4.9.3 <5.1.0.
  • zone.js must be updated to 0.14.0.

@laurentgrangier
Copy link
Contributor Author

laurentgrangier commented May 13, 2024

When running test for angular-material, I get lot of the following error:

Error: NG0402: A required Injectable was not found in the dependency injection tree. If you are bootstrapping an NgModule, make sure that the `BrowserModule` is imported.      
        error properties: Object({ code: 402 })

If I move the code from angular-test to angular-material directly, the tests run. I wonder why the angular-test package is needed, since it is only used from angular-material. Should we not simply move all the code from angular-test to angular-material?

@JBBianchi Since you did the previous Angular upgrade. Maybe you can help here?

@JBBianchi
Copy link
Contributor

I must admit I didn't understand either what was the use of having a specific module angular-test if it's only use in one other module anyways. I don't have a lot of time currently but I can try to have a look in the next weeks.

@sdirix
Copy link
Member

sdirix commented May 13, 2024

Hi! Thanks for raising this issue and proactively working on it 👍

The Angular test package is only there for historic reasons, I don't see a problem with removing it if it makes the overall task easier.

@lucas-koehler lucas-koehler linked a pull request May 23, 2024 that will close this issue
@lucas-koehler lucas-koehler added this to the 3.3 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants