Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser tests are not executed for Edge browser #671

Open
HeikoKlare opened this issue May 15, 2023 · 0 comments · May be fixed by #672
Open

Browser tests are not executed for Edge browser #671

HeikoKlare opened this issue May 15, 2023 · 0 comments · May be fixed by #672
Labels
junit JUnit test failure

Comments

@HeikoKlare
Copy link
Contributor

Describe the bug
The browser tests Test_org_eclipse_swt_browser_Browser are currently only executed with flag SWT.NONE. On WIndows systems, this results in tests only being executed for the IE browser, but not for the Edge browser.

Expected behavior
Browser tests should be parameterized with relevant configurations to test. This particularly involves the Edge browser implementation on Windows.

Environment:

  1. Select the platform(s) on which the behavior is seen:
    • All OS
    • Windows
    • Linux
    • macOS

  1. Additional OS info (e.g. OS version, Linux Desktop, etc)
    irrelevant

  2. JRE/JDK version
    irrelevant

Version since
Probaby always

Workaround (or) Additional context
Regression tests were not run for the changes in #660, as the changes affect the Edge browser and tests are only execute for IE.
@HeikoKlare HeikoKlare added the junit JUnit test failure label May 15, 2023
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue May 15, 2023
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
c94d567 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue May 15, 2023
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
a1c51fb 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue May 16, 2023
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
6c9c790 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue May 22, 2023
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
4064741 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes eclipse-platform#672
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue May 23, 2023
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
31c2a39 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue May 23, 2023
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
549a829 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
@HeikoKlare HeikoKlare linked a pull request May 23, 2023 that will close this issue
Draft
jukzi pushed a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Jun 15, 2023
@HeikoKlare @jukzi
Parameterize browser tests to execute them for Edge browser eclipse-p…
0336d1c 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Jan 30, 2024
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
a8cadf8 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Jan 30, 2024
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
55b95be 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Jan 30, 2024
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
9dd213d 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Jan 31, 2024
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
b002ced 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Feb 1, 2024
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
4d2a5a1 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
HeikoKlare added a commit to HeikoKlare/eclipse.platform.swt that referenced this issue Feb 5, 2024
@HeikoKlare
Parameterize browser tests to execute them for Edge browser eclipse-p…
fde88d9 
…latform#671

Browser tests were only executed for the default configuration of a
system's browser using the SWT.NONE flag. Other configurations, such as
using the Edge browser in Windows, were not tested.

This change parameterizes the browser tests to also execute them for the
Edge browser on Windows. It also deactivates those tests for the Edge
browser for which the implementation does (currently) not work. This
allows to detect regressions when performing future changes to the Edge
browser.

Fixes
eclipse-platform#671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
junit JUnit test failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parameterize browser tests to execute them for Edge browser #671 HeikoKlare/eclipse.platform.swt
1 participant
@HeikoKlare