Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Keycloak resources for authorization instead of dynamically created roles #984

Open
mmurto opened this issue Sep 5, 2024 · 1 comment
Labels
question Further information is requested

Comments

@mmurto
Copy link
Contributor

mmurto commented Sep 5, 2024

As a warning, I'm not super deep in Keycloak. Nevertheless, the way ORT Server uses Keycloak's client roles dynamically (permission_organization_$ORGID_write etc.) seems unintuitive. What ORT Server wants to do is to protect resources (organizations, products etc.), and for that Keycloak has native functionality to manage resources, policies and permissions. To me this seems like a better fit than the current method of handling authorization. There have also been some reports where large number of roles has led to performance issues (though the specific prolem may have been solved in later releases), and with the current authorization model the role count grows very large.

What is the reason for going with these dynamic roles for authorization instead of Keycloak's resource authorization service?

@sschuberth sschuberth added the question Further information is requested label Sep 5, 2024
@mnonnenmacher
Copy link
Contributor

I totally agree with that. I wanted to look into resources since the initial implementation but never found the time.

@mmurto In the context of #504, do you know if the other auth providers you suggest there have similar features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants