Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve test_grid_global temp fix #84

Open
brey opened this issue Jan 28, 2022 · 2 comments
Open

resolve test_grid_global temp fix #84

brey opened this issue Jan 28, 2022 · 2 comments

Comments

@brey
Copy link
Collaborator

brey commented Jan 28, 2022

I have resolved temporarily an issue with jigsaw and the in-house ocean coastlines. It works with cbuffer now so it might be the quality of the coastlines or something in the configuration.

Strangely the same cbuffer with the gmsh option doesn't pass the schism validation.

Latest version of jigsaw needs more testing.
@brey
Copy link
Collaborator Author

brey commented Jan 30, 2022

In addition, the included ocean coastlines should include a split-up polygon on the international zone line.

brey added a commit to brey/pyPoseidon-dev that referenced this issue Jan 30, 2022
@brey
Fix tests
bd831e0 
Make sure that tests can run with `pyposeidon-base`
Remove `cartopy` dependency from tests
Replace `jigsaw` with `gmsh` and bypass  ec-jrc#84
@pmav99 pmav99 mentioned this issue Aug 22, 2024
Closed
@brey
Copy link
Collaborator Author

brey commented Aug 24, 2024

Is seems that jigsaw is very sensitive to that. I have updated the coastlines and the test passes on OSX but not on Linux. It turns out that even 10e-14 changes in the coastline numbers is enough to get jigsaw to stuck. Time permitting, I will investigate more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brey