Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate iso-dem feature #59

Open
brey opened this issue Nov 17, 2021 · 6 comments
Open

Elaborate iso-dem feature #59

brey opened this issue Nov 17, 2021 · 6 comments
Assignees

Comments

@brey
Copy link
Collaborator

brey commented Nov 17, 2021

Test [min,max] option. Expand to global.

@brey brey self-assigned this Nov 17, 2021
@huyquangtranaus
Copy link
Contributor

Hi @brey is there any idea how to let the code use several dem *.nc sources? I hope you could understand my question because sometimes we have a very large domain and we want to refine the mesh only in the area of interest where we often have a high-resolution bathymetry. Thank you

@brey
Copy link
Collaborator Author

brey commented Jun 2, 2022

Indeed @huyquangtranaus this is an issue. This is important when the dem is also provided in tiles and one needs a single file for pyposeidon.

However, merging different dem files with different resolutions is not trivial and in theory should be done independently in advance. I would support a new package that would do just that. It is also part of the discussion here.

In fact, this particular feature (iso-dem boundary) is put on hold because it requires a HR bathymetry to provide added value as opposed to a coastline contour. I have to setup a proper example in order to test the option.

It is envisioned that requiring different resolution on the mesh generation aspect by defining an area of interest will be included (there is a preliminary setup for jigsaw but not tested or expanded to gmsh). However this pertains to appropriate mesh scaling not the dem values themselves.

@huyquangtranaus
Copy link
Contributor

Thanks @brey, have you ever tested with large bathymetry data? . I tried to read a DEM file with a size of lat=6687 x lon=7087, but the job was killed... :( , without DEM, everything works fine.

@brey
Copy link
Collaborator Author

brey commented Jun 6, 2022

Hi @huyquangtranaus. You are right. I have the same problem with gebco but I haven't had the time to work on it. I have opened #104 to follow it.

@brey
Copy link
Collaborator Author

brey commented Jun 7, 2022

@huyquangtranaus Try setting adjust_dem=False in setup arguments. You might get further.

@huyquangtranaus
Copy link
Contributor

Hi George @brey, spent a full last Sunday to play with the mesh generation :)), I did see and try adjust_dem=False option, but the issue was still there. Indeed, the code was killed when I used the "full" GHHS shoreline too, so I ended up using the "high" resolution and coarse bathymetry. After all, I was able to generate a mesh of 130k nodes (QLD Australia) and testing it now. Although I am keen on digging into this issue further, everything looks pretty promising now as my setup with the mesh is running smoothly...happy with the tool :)

Thanks George

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants