Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #60

Open
2 tasks done
ademarco opened this issue Oct 20, 2017 · 1 comment
Open
2 tasks done

Improve logging #60

ademarco opened this issue Oct 20, 2017 · 1 comment
Assignees
Labels

Comments

@ademarco
Copy link
Collaborator

ademarco commented Oct 20, 2017

We should implement the following:

  • Add debug level for parsing event
  • Add sent response event for notification as info level

Also rename event classes as suggested on https://symfony.com/doc/current/components/event_dispatcher.html#naming-conventions

Naming Conventions
The unique event name can be any string, but optionally follows a few simple naming conventions:

Use only lowercase letters, numbers, dots (.) and underscores (_);
Prefix names with a namespace followed by a dot (e.g. order., user.*);
End names with a verb that indicates what action has been taken (e.g. order.placed).
@ademarco ademarco self-assigned this Oct 20, 2017
ademarco added a commit that referenced this issue Oct 20, 2017
ademarco added a commit that referenced this issue Oct 20, 2017
@ademarco
Copy link
Collaborator Author

This is ready for review @netlooker @imanoleguskiza

ademarco added a commit that referenced this issue Oct 20, 2017
@ademarco ademarco added the 1.0.0 label Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant