Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEPT-1534: Double-check component implementation for inconsistencies: #22

Open
2 of 6 tasks
ademarco opened this issue Sep 22, 2017 · 1 comment
Open
2 of 6 tasks
Labels

Comments

@ademarco
Copy link
Collaborator

ademarco commented Sep 22, 2017

In particular:

  • Component is using but we currently use instead
  • is not mentioned in documentation but we are using it, clarify this
  • For contacts, we use type auteur, we don't use 'planningUnit' neither 'translationUnit': check which one to keep
  • In EC\Poetry\Messages\Components\ReturnAddress 'WebService' should start with lowercase in (2x) 'expression' => 'this.getType() == "webService"': Check this.
  • "ReturnAddress()->setRemark" call: Why is it mandatory to call it when we introduce a blank? the blank value cannot be the default value?
  • Add tests for all tasks above
@ademarco ademarco changed the title NEPT-1458: Double-check component implementation for inconsistencies: NEPT-1534: Double-check component implementation for inconsistencies: Sep 22, 2017
@ademarco
Copy link
Collaborator Author

We are removing this temporarily, we will need to better check it:

class Identifier extends AbstractComponent
...
        $metadata->addConstraint(new Assert\Expression([
            'expression' => 'this.getSequence() || this.getNumber() ',
            'message' => 'An identifier must have a number or a sequence.',
        ]));
        $metadata->addConstraint(new Assert\Expression([
            'expression' => '(this.getSequence() && this.getNumber()) == false ',
            'message' => 'An identifier can\'t have both a number and a sequence.',
        ]));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant