Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Memory Leak?? #23

Open
Edison-Hsu opened this issue Feb 24, 2018 · 2 comments
Open

Potential Memory Leak?? #23

Edison-Hsu opened this issue Feb 24, 2018 · 2 comments

Comments

@Edison-Hsu
Copy link

Hi, Thank you for nice puppeteer project.

I finished my puppeteer project by reference backend/server.js file.
In my case, I got a little memory leak. Because I did not call browser.disconnect() before reusing the browser object.

I read the backend/server.js file again. I did not find codes be related with disconnect browser. So I guess maybe try-puppeteer got the same memory leak problem ?

@ebidel
Copy link
Owner

ebidel commented Feb 24, 2018

Yea good call. There should probably be a disconnect somewhere just to be safe. Want to submit a PR?

@Edison-Hsu
Copy link
Author

Sure. My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants